Uncrispyfy foundation5 field #3000
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 31s ⏱️ Results for commit e07a0a0. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3000 +/- ##
==========================================
+ Coverage 56.60% 56.76% +0.16%
==========================================
Files 602 603 +1
Lines 43722 43720 -2
Branches 48 48
==========================================
+ Hits 24747 24816 +69
+ Misses 18963 18892 -71
Partials 12 12 ☔ View full report in Codecov by Sentry. |
podliashanyk
force-pushed
the
uncrispyfy/foundation5-field
branch
2 times, most recently
from
67ec912 to
3ffff83
Compare
|
Just an initial comment before I actually review: Yes, crispy-forms-foundation is mostly based on regular Django templates. NAV is currently (in principle) locked to You've discovered some of NAV's own overrides to those templates :) |
There was a problem hiding this comment.
This looks good to me. Essentially, we would just be re-implementing our own custom subset of crispy-forms if we go down this route, and that might be good enough.
The important part of it is that we shouldn't have to write complete form templates over and over, when crispy-forms is essentially just about re-using the same template over and over.
This template is extensively used across the whole site. Also removes redundant checkbox class append which is not defined anywhere in CSS and is never rendered in computed styles in browser.
podliashanyk
force-pushed
the
uncrispyfy/foundation5-field
branch
from
e297c5f to
3b1f0f5
Compare
podliashanyk
force-pushed
the
uncrispyfy/foundation5-field
branch
from
3b1f0f5 to
e07a0a0
Compare
| # Copied from | ||
| # https://github.com/django-crispy-forms/django-crispy-forms/blob/1.8.1/crispy_forms/templatetags/crispy_forms_field.py |
There was a problem hiding this comment.
This is so trivial that I wouldn't bother with citing a source...
Introduces a reusable field template for #2794 (see 550de56).
Found
templates/foundation-5/field.htmlhidden gem, which is implicitly (and explicitly) used in forms across the app.This PR as-is fixes:
/sedddb#2996 (see updated list there)Best reviewed: commit-for-commit.